This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
Implement "strict" mode. #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levels of strictness: - `PROCESS`: Abort process by throwing an exception. - `RECORD`: Ignore (skip) record and log an error. - `EXPRESSION`: Ignore (skip) expression and log a warning. Introduces `FixProcessException` to differentiate from `FixExecutionException`: The latter indicating potentially data-dependent issues that should be subject to strictness handling, while the former should only refer to static issues with the usage of Fix expressions.
fsteeg
approved these changes
Mar 31, 2022
fsteeg
added a commit
that referenced
this pull request
Mar 31, 2022
blackwinter
added a commit
that referenced
this pull request
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192.
Levels of strictness:
PROCESS: Abort process by throwing an exception. This is the current behaviour and the new default.RECORD: Ignore (skip) failed record and log an error.EXPRESSION: Ignore (skip) failed expression and log a warning.Introduces
FixProcessExceptionto differentiate fromFixExecutionException: The latter indicating potentially data-dependent issues that should be subject to strictness handling, while the former should only refer to static issues with the usage of Fix expressions.Areas for future work:
nexpressions have failed, fail the record; oncenrecords have failed, fail the process.maybe()bind).(NOTE: We can't test for expected exceptions/errors in integration tests yet.)(Resolved by e167bbe.)